-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Fix building thermostat #22073
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:efr32_fix_wifi_thermostat
Aug 23, 2022
Merged
[EFR32] Fix building thermostat #22073
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:efr32_fix_wifi_thermostat
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
saurabhst
August 22, 2022 14:49
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 22, 2022 14:49
PR #22073: Size comparison from b85c5ec to 47221b9 Increases (3 builds for cc13x2_26x2, psoc6)
Decreases (4 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
/rebase |
andy31415
reviewed
Aug 22, 2022
jmartinez-silabs
approved these changes
Aug 22, 2022
jepenven-silabs
force-pushed
the
efr32_fix_wifi_thermostat
branch
from
August 22, 2022 18:27
a6b55fd
to
08b8f95
Compare
/rebase |
andy31415
approved these changes
Aug 22, 2022
PR #22073: Size comparison from a71a002 to 08b8f95 Increases (4 builds for esp32, psoc6, telink)
Decreases (4 builds for bl602, cyw30739, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
App doesn't build
Change overview
Fix building for wiFi but adding the right sources files that are missing.
In the same time, update the bitmap library to include the thermostat icon since we are now including the LCD files.
Testing
Locally on EFR platform